fix(Multichain): do not disable currently selected network in the network selector [SW-214] #4229
Conversation
Branch preview✅ Deploy successful! Storybook: |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
📦 Next.js Bundle Analysis for safe-wallet-webThis analysis was generated by the Next.js Bundle Analysis action. 🤖
|
| Page | Size (compressed) |
|---|---|
global |
979.46 KB (🟡 +25.2 KB) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
Forty-two Pages Changed Size
The following pages changed size from the code in this PR compared to its base branch:
| Page | Size (compressed) | First Load |
|---|---|---|
/ |
507 B (🟢 -24.38 KB) |
979.95 KB |
/403 |
574 B (🟢 -3 B) |
980.02 KB |
/404 |
697 B (🟢 -1 B) |
980.14 KB |
/_error |
230 B (🟡 +2 B) |
979.68 KB |
/_offline |
1.09 KB (🟢 -3 B) |
980.55 KB |
/addOwner |
535 B (🟡 +1 B) |
979.98 KB |
/address-book |
26.11 KB (🟡 +16 B) |
1005.57 KB |
/apps |
50.17 KB (🟢 -11 B) |
1.01 MB |
/apps/bookmarked |
446 B (🟡 +1 B) |
979.89 KB |
/apps/custom |
41.79 KB (🟢 -17 B) |
1021.25 KB |
/apps/open |
54.74 KB (🟡 +2 B) |
1.01 MB |
/balances |
30.66 KB (🟢 -340 B) |
1010.11 KB |
/balances/nfts |
19.16 KB (🟢 -19 B) |
998.62 KB |
/cookie |
8.76 KB (🟡 +27 B) |
988.22 KB |
/home |
60.91 KB (🟡 +707 B) |
1.02 MB |
/imprint |
1.38 KB (🟡 +2 B) |
980.83 KB |
/licenses |
4.97 KB (🟢 -3 B) |
984.42 KB |
/new-safe/advanced-create |
36.39 KB (🟡 +1.24 KB) |
1015.84 KB |
/new-safe/create |
35.64 KB (🟡 +1.23 KB) |
1015.09 KB |
/new-safe/load |
16.38 KB (🟢 -32 B) |
995.84 KB |
/privacy |
15.9 KB (🟡 +24 B) |
995.35 KB |
/settings |
450 B (🟢 -1 B) |
979.89 KB |
/settings/appearance |
8.02 KB (🟢 -20 B) |
987.47 KB |
/settings/cookies |
7.64 KB (🟢 -26 B) |
987.09 KB |
/settings/data |
7.54 KB (🟢 -22 B) |
986.99 KB |
/settings/environment-variables |
9.13 KB (🟢 -25 B) |
988.58 KB |
/settings/modules |
9.76 KB (🟢 -21 B) |
989.22 KB |
/settings/notifications |
27.85 KB (🟡 +835 B) |
1007.3 KB |
/settings/safe-apps |
25.55 KB (🟢 -13 B) |
1005.01 KB |
/settings/security |
8.06 KB (🟢 -25 B) |
987.52 KB |
/settings/setup |
35.96 KB (🟢 -24 B) |
1015.41 KB |
/share/safe-app |
9.72 KB (🟢 -3 B) |
989.18 KB |
/stake |
589 B (🟢 -13 B) |
980.03 KB |
/swap |
723 B (🟢 -9 B) |
980.16 KB |
/terms |
11.24 KB (🔴 +10.71 KB) |
990.7 KB |
/transactions |
73.47 KB (🟢 -57 B) |
1.03 MB |
/transactions/history |
73.44 KB (🟢 -58 B) |
1.03 MB |
/transactions/messages |
39.12 KB (🟢 -46 B) |
1018.57 KB |
/transactions/msg |
29.5 KB (🟢 -18 B) |
1008.96 KB |
/transactions/queue |
31.22 KB (🟢 -46 B) |
1010.68 KB |
/transactions/tx |
21.05 KB (🟢 -18 B) |
1000.51 KB |
/welcome |
6.77 KB (🟢 -4 B) |
986.22 KB |
Details
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.
Coverage report
Show files with reduced coverage 🔻
Test suite run success1539 tests passing in 206 suites. Report generated by 🧪jest coverage report action from a27ec22 |
katspaugh
changed the title
jmealy
changed the title
What it solves
In the network multi select for safe creation, if the selected network does not have the multichain feature enabled, then the network is disabled after selection, so you cannot deselect it.
How this PR fixes it
If the feature is not enabled on the currently selected network, all other networks are disabled, but the currently selected one is not.
How to test it
Screenshots
Before:
After:
Checklist